Re: [PATCH net] net: ena: avoid double-counting TX DMA mappings on failure

From
Arthur Kiyanovski <akiyano@amazon.com>
Date
2026-11-11 23:40:11
Reply to
Avi Weiss, 2026-11-09
On Mon, 09 Nov 2026 14:39:34 +0200, Avi Weiss [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
index 7eb6456ed0d5..e0df628e1df6 100644
--- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
+++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
@@ -2608,7 +2608,6 @@ static int ena_tx_map_skb(struct ena_ring *tx_ring,
 
 	tx_info->skb = NULL;
 
-	tx_info->num_of_bufs += i;
 	ena_unmap_tx_buff(tx_ring, tx_info);
 
 	return -EINVAL;
Like you wrote this one has already been applied to the amzn-drivers
repository:

https://github.com/amzn/amzn-drivers/commit/1d6a78cebd2d7c38b4dbdee572ab3d3755086248

Therefore please do the following:

1. Add a From: tag to give credit to Evgeny Ostrovsky, who wrote this fix 
   (without leading "-"):

- From: Evgeny Ostrovsky [off-list ref]

This should be first line before "ena_tx_map_skb() increme..."

2. Evgeny has agreed, please also add (without leading "-"):

- Signed-off-by: Evgeny Ostrovsky [off-list ref]

It should be added before your Signed-off-by:

-- 
Arthur Kiyanovski [off-list ref]
Thread (6 messages) 6 messages, 4 authors, last reply 5d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help