Re: [PATCH 1/2] net: phy: motorcomm: add led_brightness_set for YT8521

From
Chukun Pan <hidden>
Date
2026-11-11 06:50:20
Also in
lkml
Reply to
Andrew Lunn, 2026-11-10
Hi,
Has this been tested on real hardware?
I tested yt8531 on some SBCs and will add this to the commit message.
Have you had it blinking the heartbeat? Shift-lock etc.
Only supports forced LED on/off. Forced blink is disabled by default.
Do I need to implement heartbeat?
I _think_ this is the wrong place to insert these.

The sorting of registers is a bit messed up in this driver, but i
think you need to insert before:

#define YTPHY_PAD_DRIVE_STRENGTH_REG		0xA010
Indeed, I will correct this.

Thanks,
Chukun
Thread (9 messages) 9 messages, 3 authors, last reply 7d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help