Re: [PATCH net-next] net: ena: set admin device pointer before queue allocations

From
Arthur Kiyanovski <akiyano@amazon.com>
Date
2026-11-10 18:42:45
Reply to
Avi Weiss, 2026-11-09
On Mon, 09 Nov 2026 09:11:27 +0200, Avi Weiss [off-list ref] wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/ethernet/amazon/ena/ena_com.c b/drivers/net/ethernet/amazon/ena/ena_com.c
index 297fb36ab8c1..23b3ef50b8b6 100644
--- a/drivers/net/ethernet/amazon/ena/ena_com.c
+++ b/drivers/net/ethernet/amazon/ena/ena_com.c
@@ -2045,7 +2047,6 @@ int ena_com_admin_init(struct ena_com_dev *ena_dev,
 	if (ret)
 		goto error;
 
-	admin_queue->ena_dev = ena_dev;
 	admin_queue->running_state = true;
 
 	return 0;
1. This is a bug fix, so it should go to net and not net-next.

2. Like your other patches, this one has already been applied to the
amzn-drivers repository:

https://github.com/amzn/amzn-drivers/commit/7d1dc4341d4f8376c7affdc2a97c7e012118beaa

Therefore please do the following:

2.1. Add a From: tag to give credit to Wajeeh Atrash, who wrote this fix:

From: Wajeeh Atrash <redacted>

2.2. Wajeeh has agreed, please also add:


It should be added before your Signed-off-by:

2.3. Move "admin_queue->ena_dev = ena_dev;" to the same place as in the
github commit, which is directly above the q_dmadev assignment:

        admin_queue->ena_dev = ena_dev;
        admin_queue->q_dmadev = ena_dev->dmadev;

I don't see a clear advantage to the location in your patch, so I would
rather have both drivers aligned.

Signed-off-by: Wajeeh Atrash <redacted>

-- 
Arthur Kiyanovski [off-list ref]
Thread (4 messages) 4 messages, 3 authors, last reply 5d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help