Re: [PATCH 1/2] net: thunderbolt: Stop queueing Rx buffers if allocation fails

From
Mika Westerberg <mika.westerberg@linux.intel.com>
Date
2026-11-10 14:21:48
Reply to
netdev-bot+sashiko@kernel.org, 2026-11-07
Hi,

On Sat, Nov 07, 2026 at 03:55:08PM +0000, netdev-bot+sashiko@kernel.org wrote:
Thank you for your contribution! Sashiko AI review found 5 potential
issue(s) to consider.

Critical: 0 · High: 3 · Medium: 0 · Low: 2

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [High] tbnet_poll() (drivers/net/thunderbolt/main.c) can stop Rx
  permanently when a refill fails.
- [High] The new deficit-based cleaned_count in tbnet_poll() (lines
  829-831) lets a NAPI poll that runs after teardown allocate and strand…
- [High] tbnet_poll() no longer completes NAPI while allocations keep
  failing and the ring is empty (the new `return budget` at line 936),…
I agree all of them. I will submit v2 with these fixed.

pw-bot: cr
Thread (5 messages) 5 messages, 3 authors, last reply 8d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help