On Wed 04-11-26 18:27:24, Christian Brauner wrote:
nlm_end_grace_read() answers with "Y\n" or "N\n" from a three byte
buffer and hands out all three bytes, the terminating NUL included.
Leave the NUL out.
Fixes: d68e3c4aa416 ("lockd: add a /proc/fs/lockd/nlm_end_grace file")
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
Makes sense. Feel free to add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
quoted hunk ↗ jump to hunk
---
fs/lockd/procfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/lockd/procfs.c b/fs/lockd/procfs.c
index a01f08c8c2f3..74f7ab77535a 100644
--- a/fs/lockd/procfs.c
+++ b/fs/lockd/procfs.c
@@ -57,7 +57,7 @@ nlm_end_grace_read(struct file *file, char __user *buf, size_t size,
resp[1] = '\n';
resp[2] = '\0';
- return simple_read_from_buffer(buf, size, pos, resp, sizeof(resp));
+ return simple_read_from_buffer(buf, size, pos, resp, sizeof(resp) - 1);
}
static const struct proc_ops lockd_end_grace_proc_ops = {
--
2.53.0
--
Jan Kara [off-list ref]
SUSE Labs, CR