Re: [PATCH net-next v3 8/9] net: devmem: size TX net_iovs from the dmabuf sg table

From
Stanislav Fomichev <hidden>
Date
2026-11-09 18:29:18
Also in
linux-doc, linux-kselftest, linux-rdma, lkml
Reply to
netdev-bot+sashiko@kernel.org, 2026-11-09
[Severity: Medium]
netdev_nl_bind_tx_doit() now passes niov_shift == 0, so a hugepage-backed
dmabuf gets 2MB TX net_iovs. Can a devmem TX frag then end up larger than
dev->netmem_tx_max_frag_size?
[..]
Is a cap applied only at build time enough to keep that contract?
It's not, same as reported for patch 4. In v4 tcp_clone_payload()
won't merge net_iov frags, which keeps the cap with large net_iovs.
There is also a related issue in the same code. It is pre-existing and
was not introduced by this patch.
[..]
Would either of these fix both problems:

  - compare skb_frag_netmem() and apply binding->tx_max_frag_size in
    tcp_clone_payload()
  - don't coalesce unreadable skbs when building MTU probes
Not merging net_iov frags in tcp_clone_payload() fixes both. Mina's
series also compares skb_frag_netmem() there:
https://lore.kernel.org/netdev/20261108013838.1454450-3-almasrymina@google.com/ (local)
Thread (26 messages) 26 messages, 4 authors, last reply 10d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help