Re: [PATCH net-next 3/5] net: rnpgbe: Support copper link configuration

From
Yibo Dong <dong100@mucse.com>
Date
2026-11-09 09:22:23
Also in
lkml
Reply to
Andrew Lunn, 2026-11-07
On Sat, Nov 07, 2026 at 07:04:20PM +0100, Andrew Lunn wrote:
quoted
@@ -236,7 +236,7 @@ int mucse_mbx_set_link(struct mucse_hw *hw, u32 advertising, bool autoneg,
 
 	len = le16_to_cpu(req.r.datalen);
 	mutex_lock(&hw->mbx.lock);
-	err = mucse_write_and_wait_ack_mbx(hw, req.dwords, len);
+	err = mucse_write_mbx_coalesce_event(hw, req.dwords, len);
 	mutex_unlock(&hw->mbx.lock);
This seems out of place.
This is needed because the new ethtool setter can configure a running
interface while firmware link-event reporting is enabled. Commands and
events share the mailbox buffer, so a pending event could be overwritten
by a command.
The coalescing helper acknowledges the pending event under the hardware
mailbox lock without updating the link-state snapshot, allowing firmware
to report the current state again.
Would you prefer this change to be split into a separate preparatory
patch, or would explaining the dependency in the commit message be
sufficient?
     Andrew
Thanks for your feedback.
Thread (15 messages) 15 messages, 3 authors, last reply 11d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help