Thanks Maxime for reviewing!
On 06/11/2026 11:11 am, Maxime Chevallier wrote:
quoted
+/**
+ * phylink_mac_interrupt() - wrapper for phy_mac_interrupt()
+ * @pl: a pointer to a &struct phylink returned from phylink_create()
+ *
+ * Passes a link-change interrupt received by the MAC to phylib.
+ * This function may be called in interrupt context, and therefore cannot take
+ * a mutex. However, it is safe to assume that the reference to phy does not
+ * disappear during the call, as only an SFP module may be unplugged to make a
+ * PHY disappear. SFP modules however do not support interrupts.
I don't see the relevance of PHY SFP supporting interrupts or not here,
this just re-triggers the PHY state machine. Looks like a comment to
make sashiko happy.
Indeed, this is for sashiko. Unfortunately it followed up with: "The function comment notes that SFP modules do not support interrupts. However, when an SFP module is physically unplugged, the electrical link drops. Could this link drop trigger the MAC interrupt being handled here?", which is equally irrelevant, I believe.
Anyways, I'm OK with the approach, maybe reword that comment if you need
to respin,
Reviewed-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Thanks, will add.
Birger