Re: [PATCH net-next] net: ethernet: adi: adin1110: Fix phy_device leak in probe_netdevs()

From
Xia Yan <hidden>
Date
2026-11-06 07:53:07
Also in
lkml
Reply to
netdev-bot+sinfo@kernel.org, 2026-11-06
On 11/6/26 15:27, netdev-bot+sinfo wrote:
 - Whether the issue was actually triggered, or is only theoretical
   (e.g. found by code inspection). If it was triggered please include
   the symptoms, like the stack trace or error messages.

 - What hardware the change was tested on. For driver fixes please
   mention the device (and if relevant firmware version) used for
   testing, or say that the change was not tested on real hardware.
Hi,

The leak was not hit at runtime. I found it by code inspection while
reviewing the MDIO attach paths, as the commit message notes. There is
no stack trace: the effect would be one struct phy_device allocated
per port on every probe and never released.

I don't have ADIN1100 or ADIN2111 hardware, so the change is
compile-tested only, with CONFIG_ADIN1110 enabled on x86_64.

Thanks,
Xia Yan

Thread (4 messages) 4 messages, 3 authors, last reply 1d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help