Re: [PATCH net-next v2 3/4] net: add skb_frags_can_coalesce() helper

From
Stanislav Fomichev <hidden>
Date
2026-11-03 22:43:40
Also in
io-uring, lkml
Reply to
Mina Almasry, 2026-11-02
On 11/02, Mina Almasry wrote:
Add skb_has_net_iovs(skb), assuming skb->unreadable and net_iov-backed
frags are equivalent for now (with a comment noting the two can be
decoupled in the future if readable net_iovs are introduced).

Also add skb_mem_provider_compat() and skb_frags_can_coalesce() so all
multi-skb coalescing, shifting, and GRO paths can share a single check
across pp_recycle, skb_zcopy(), and fragment memory providers:
- empty 0-length skbs are compatible without mixing readable payload
- page vs net_iov is rejected via skb_has_net_iovs() (0 pointer chases)
- page vs page is allowed via !skb_has_net_iovs() (0 pointer chases)
- net_iov vs net_iov compares mp_priv (walking frag_list if nr_frags is 0)
Maybe squash this and patch #4? Otherwise hard to follow :-(
Thread (8 messages) 8 messages, 2 authors, 16h ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help