Hi,
Here is the information missing from the changelog:
- How the issue was found: during a code review of the driver that was
assisted by an AI coding assistant (an LLM). The assistant compared
adin1110_net_stop() against the bit definitions and the mapping used by
adin1110_port_rx_ready(); I then checked the finding against the register
semantics used by adin1110_net_open() (IMASK1: 1 = masked).
- Triggered or theoretical: theoretical. I have not triggered it and there
is no reproducer. Expected symptoms if it is hit: on ADIN2111, bringing
one port down masks the peer port's RX-ready interrupt so the peer stops
receiving, while the port that was brought down keeps its own RX interrupt
enabled; since the interrupt is level triggered and
adin1110_read_frames() skips the FIFO while netif_oper_up() is false,
pending frames keep re-asserting it. On the single-port ADIN1110 the RX
interrupt is never masked at all.
- Hardware: none. The change was not tested on real hardware; it was
compile-tested only (CONFIG_ADIN1110=m, x86_64) and passes
scripts/checkpatch.pl --strict.
Per Documentation/process/generated-content.rst, the tool assistance is
noted above. I have reviewed the analysis and the change and take
responsibility for them.
If another revision is needed, I will fold this information into the
commit message.
Thanks,
Yuehong Wu