Re: [PATCH net v3 2/4] net: phy: as21xxx: fix read_status speed handling

From
Paolo Abeni <pabeni@redhat.com>
Date
2026-11-03 08:56:30
Also in
lkml
Reply to
netdev-bot+sashiko@kernel.org, 2026-10-30
On 10/30/26 11:32, netdev-bot+sashiko@kernel.org wrote:
Thank you for your contribution! Sashiko AI review found 6 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 5 · Low: 1

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] With AUTONEG_DISABLE, as21xxx_read_status() no longer takes
   speed/duplex from the PHY.
- [Medium] In autoneg mode, as21xxx_read_status() now reads
   VEND1_SPEED_STATUS on every link-up, which is the PHY's own report of…
- [Medium] The new early `if (!phydev->link) return 0;` in
   as21xxx_read_status() (drivers/net/phy/as21xxx.c:732-733) makes the…
- [Medium] In forced mode (AUTONEG_DISABLE), phydev->speed/duplex hold
   the user's configuration.
- [Medium] net: phy: as21xxx: missed pause and <=1G speed in
   as21xxx_read_status()
The above ones looks legit to me.

/P
Thread (9 messages) 9 messages, 3 authors, last reply 13d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help