ionic waits a fixed 5 seconds for device and admin queue commands, and
the RDMA driver gives its admin queue 2 seconds. Some commands can take
the firmware longer than that, for example while a PFC configuration
change flaps the links. The firmware is alive but slow, yet the
timed-out command and everything queued behind it fail, and an RDMA
admin queue timeout resets the RDMA LIF so that later verbs fail with
-ENODEV.
Patch 1 makes the timeout a per-device value without changing it.
Patch 2 has the RDMA admin queue use the ionic command timeout instead
of its own 2 seconds. Patch 3 adds a permanent devlink parameter,
cmd_timeout, stored in device NVM, that lengthens the timeout on
firmware that supports it.
Tested on an AMD Pensando adapter under KASAN and lockdep, including
repeated PCI resets with concurrent parameter reads.
This series was developed with the help of an LLM-based coding
assistant (Claude).
---
Arun Kumar Prakash (3):
ionic: make the command timeout per device
RDMA/ionic: Use the ionic command timeout for the admin queue
ionic: add devlink param for command timeout
Documentation/networking/devlink/ionic.rst | 29 +++++++
drivers/infiniband/hw/ionic/ionic_admin.c | 9 ++-
drivers/net/ethernet/pensando/ionic/ionic.h | 15 +++-
drivers/net/ethernet/pensando/ionic/ionic_api.h | 8 ++
drivers/net/ethernet/pensando/ionic/ionic_aux.c | 8 +-
.../net/ethernet/pensando/ionic/ionic_bus_pci.c | 4 +
drivers/net/ethernet/pensando/ionic/ionic_dev.c | 90 ++++++++++++++++++++--
drivers/net/ethernet/pensando/ionic/ionic_dev.h | 3 +
.../net/ethernet/pensando/ionic/ionic_devlink.c | 89 +++++++++++++++++++++
.../net/ethernet/pensando/ionic/ionic_devlink.h | 2 +
.../net/ethernet/pensando/ionic/ionic_ethtool.c | 12 +--
drivers/net/ethernet/pensando/ionic/ionic_fw.c | 8 +-
drivers/net/ethernet/pensando/ionic/ionic_if.h | 8 ++
drivers/net/ethernet/pensando/ionic/ionic_lif.c | 13 ++--
drivers/net/ethernet/pensando/ionic/ionic_main.c | 17 ++--
15 files changed, 281 insertions(+), 34 deletions(-)
---
base-commit: 4dd16e31135ea8437a720222df34e8745f385d6d
change-id: 20261102-b4-ionic-cmd-timeout-c704d5304b4f
Best regards,
--
Nikhil P. Rao [off-list ref]