Re: [PATCH v2 01/12] dt-bindings: clock: qcom: Add bindings for PDM GP_MN clock divider

From
Konrad Dybcio <hidden>
Date
2026-11-02 15:08:40
Also in
linux-arm-msm, linux-clk, linux-devicetree, linux-gpio, lkml
Reply to
Taniya Das, 2026-10-29
On 10/29/26 11:57 AM, Taniya Das wrote:

On 10/28/2026 12:17 AM, Krzysztof Kozlowski wrote:
quoted
On Mon, Oct 26, 2026 at 04:59:27PM +0530, Taniya Das wrote:
quoted
Add device tree bindings for the Qualcomm Peripheral Web's PDM GP_MN
clock divider. The hardware generates a fractional output frequency
from a fixed input clock (typically TCXO4) using the relation
Fout = Fin * (M / N), with duty cycle controlled by a separate D
register. The clock output is routed over a gpio controlled pin.

Signed-off-by: Taniya Das <redacted>
---
[...]
quoted
quoted
+  assigned-clocks:
+    maxItems: 1
+    description: Parent clock phandle used to set the input frequency.
+
+  assigned-clock-rates:
+    maxItems: 1
+    description: |
+      Rate for the parent clock in Hz.
+      Supported rates: 19200000, 9600000, 6400000, 4800000.
Neither assigned-clocks nor assigned-clock-rates should be needed.
Parent clock is outside of scope of this binding.
Sure I will remove, but the parent clock input is a requirement of the
Hardware and the output of this module entirely depends on the above
ranges of frequencies mentioned and that is the reason to keep the rates
specifically. I will capture it in the description and hope that should
be fine.
So this is essentially xo, xo/2, xo/3, xo/4. The gcc_pdm_xo4_div_clk_src
you added is defined as a 4-wide divider - do we need to limit that
divider's range, or would div=0b1111=xo/15 also work?

Konrad
Thread (27 messages) 27 messages, 7 authors, last reply 7d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help