K Krzysztof Kozlowski #
Message details and related content
'ipa_mem_array_ei' is not used anywhere, so can be dropped completely.
'ipa_mem_bounds_ei' and 'ipa_mem_range_ei' are not used outside of their
units, so they can be narrowed to file-scope.
Reviewed-by: Alex Elder <redacted>
Signed-off-by: Krzysztof Kozlowski <redacted>
---
Changes in v2:
1. Fix commit author.
2. Rb rag
---
drivers/net/ipa/ipa_qmi_msg.c | 25 ++-----------------------
drivers/net/ipa/ipa_qmi_msg.h | 3 ---
2 files changed, 2 insertions(+), 26 deletions(-)
diff --git a/drivers/net/ipa/ipa_qmi_msg.c b/drivers/net/ipa/ipa_qmi_msg.c
index 51dc13a577a5..e2401d8475b6 100644
--- a/drivers/net/ipa/ipa_qmi_msg.c
+++ b/drivers/net/ipa/ipa_qmi_msg.c@@ -188,7 +188,7 @@ const struct qmi_elem_info ipa_init_complete_ind_ei[] = { }; /* QMI message structure definition for struct ipa_mem_bounds */ -const struct qmi_elem_info ipa_mem_bounds_ei[] = { +static const struct qmi_elem_info ipa_mem_bounds_ei[] = { { .data_type = QMI_UNSIGNED_4_BYTE, .elem_len = 1,
@@ -208,29 +208,8 @@ const struct qmi_elem_info ipa_mem_bounds_ei[] = { }, }; -/* QMI message structure definition for struct ipa_mem_array */ -const struct qmi_elem_info ipa_mem_array_ei[] = { - { - .data_type = QMI_UNSIGNED_4_BYTE, - .elem_len = 1, - .elem_size = - sizeof_field(struct ipa_mem_array, start), - .offset = offsetof(struct ipa_mem_array, start), - }, - { - .data_type = QMI_UNSIGNED_4_BYTE, - .elem_len = 1, - .elem_size = - sizeof_field(struct ipa_mem_array, count), - .offset = offsetof(struct ipa_mem_array, count), - }, - { - .data_type = QMI_EOTI, - }, -}; - /* QMI message structure definition for struct ipa_mem_range */ -const struct qmi_elem_info ipa_mem_range_ei[] = { +static const struct qmi_elem_info ipa_mem_range_ei[] = { { .data_type = QMI_UNSIGNED_4_BYTE, .elem_len = 1,
diff --git a/drivers/net/ipa/ipa_qmi_msg.h b/drivers/net/ipa/ipa_qmi_msg.h
index 644b8c27108b..1924ac2dfa90 100644
--- a/drivers/net/ipa/ipa_qmi_msg.h
+++ b/drivers/net/ipa/ipa_qmi_msg.h@@ -253,9 +253,6 @@ extern const struct qmi_elem_info ipa_indication_register_rsp_ei[]; extern const struct qmi_elem_info ipa_driver_init_complete_req_ei[]; extern const struct qmi_elem_info ipa_driver_init_complete_rsp_ei[]; extern const struct qmi_elem_info ipa_init_complete_ind_ei[]; -extern const struct qmi_elem_info ipa_mem_bounds_ei[]; -extern const struct qmi_elem_info ipa_mem_array_ei[]; -extern const struct qmi_elem_info ipa_mem_range_ei[]; extern const struct qmi_elem_info ipa_init_modem_driver_req_ei[]; extern const struct qmi_elem_info ipa_init_modem_driver_rsp_ei[];
--
2.53.0