Re: [PATCH net v6 0/5] more virtio-net csum hardening

From
Michael S. Tsirkin <mst@redhat.com>
Date
2026-10-29 07:22:12
Also in
lkml, virtualization
Reply to
Jakub Kicinski, 2026-10-28
On Wed, Oct 28, 2026 at 03:43:15PM -0700, Jakub Kicinski wrote:
On Sun, 25 Oct 2026 09:50:24 -0400 Michael S. Tsirkin wrote:
quoted
quoted
Apologies for reposting so frequently, I know netdev bot will be unhappy
with that.  But Paulos's report made a lot of publicity, there is a lot
of people looking into this, so I feel there's value in defending
against all this class of issues sooner rather than later.

The issues were mostly found by code inspection, but all reproduced by
me in a VM.  
Ok, I looked at netdev bot review, and there's another issue.

If a tunnel inner packet happens to have a valid header at
inner_nh_offset, it will pass all checks, but the transport header can
in fact overlap e.g. the real TCP header and checksum will overwrite
that.
Sorry for boring process stuff but FWIW the last patch also does not
apply?
-- 
pw-bot: cr
I guess I need to rebase. Still don't have an idea what to do though.

-- 
MST
Thread (15 messages) 15 messages, 4 authors, last reply 8d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help