Thread (17 messages) 17 messages, 5 authors, 3d ago

Re: [PATCH net 1/5] eth: bnxt: recycle agg buffers when Rx head buffer allocation fails

flat view

From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-10-29 00:49:42

On Wed, 28 Oct 2026 23:52:43 +0000 netdev-bot+sashiko@kernel.org wrote:
Low priority / nit picks for your consideration:

- [Low] bnxt_rx_multi_page_skb() now re-posts the head page to the device
  without dma_sync_single_for_device() when napi_build_skb() fails.
This is what I flagged in the cover letter as outstanding bugs in DMA
sync which I have separate series for.
Pre-existing issues:
- [High] This problem wasn't introduced by this patch, but the patch adds
  a new consumer of it.
Same.
- [Medium] At this commit, the XDP multi-buffer path in bnxt_rx_pkt()
  still leaks buffers when bnxt_rx_agg_netmems_xdp() fails partway.
As bot realizes this is fixed later in the series.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help