Re: [PATCH net 2/2 repost2] net/sched: sch_teql: keep skb->dev consistent on the arp-queue path

From
Jamal Hadi Salim <jhs@mojatatu.com>
Date
2026-10-27 19:45:42
Also in
stable
Reply to
Simon Horman, 2026-10-27
On Tue, Oct 27, 2026 at 2:29 PM Simon Horman [off-list ref] wrote:
On Tue, Oct 27, 2026 at 04:04:34AM -0400, Jamal Hadi Salim wrote:
quoted
On Tue, Oct 27, 2026 at 3:44 AM Jamal Hadi Salim [off-list ref] wrote:
quoted
On Tue, Oct 27, 2026 at 3:25 AM Jamal Hadi Salim [off-list ref] wrote:
quoted
On Mon, Oct 26, 2026 at 8:46 PM Jakub Kicinski [off-list ref] wrote:
quoted
On Mon, 26 Oct 2026 19:51:33 -0400 Jamal Hadi Salim wrote:
quoted
quoted
This is an AI-generated review of your patch. The human sending this
email says "Hi Jamal, passing this on for your consideration as it
seems to have got stuck somewhere."
There was nothing wrong with the headers this time - so not sure what
is going on. A bit frustrating.
It is frustrating, you are the only one with these issues.
Patch 2 is posted in reply to patch 1. IDK what else is wrong.
Let me send a repost3 - will take the opportunity to pedantically fix
the commit message (no code change).
BTW, checking i see the threading was:
     0/2 cover  (root)
       1/2      (reply to 0/2)
         2/2    (reply to 1/2)

I checked other postings that didnt have issues and it was fine. I
also found the approach
   0/2 cover  (root)
       1/2      (reply to 0/2)
        2/2    (reply to 0/2)
And for repost3:
- 0/2 (root)
     1/2  In-Reply-To/References: 0/2
     2/2  In-Reply-To: 1/2; References: 0/2 + 1/2

I am sticking to this approach going forward.
Hi Jamal,

It's unclear to me if the threading relates to why the NIPA-Sashiko review
of this patch-set didn't propagate to the ML.  But I would suggest that
however b4 handles threading would be a good approach top copy.
I looked at several patches that it didnt have any problems with (some
merged already) and it doesnt seem to care which of the two approaches
used. But i will look at what b4 format looks like for completion.
I am begining to suspect it is not the threading, more the repost
approach. The "repost" was not including any code or commit changes
and it seems to be problematic even when i changed the message ids. So
likely it is only paying attention to subject versioning i.e vX or the
body text. I added modified commit text this time on all 3, so lets
see if that fixes it (caveat: the Vx didnt change).

cheers,
jamal
Thread (12 messages) 12 messages, 3 authors, last reply 19d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help