Re: [PATCH net-next v2 1/3] net/sched: drr, ets, sfq: skip empty rounds in the deficit-refill dequeue loop

From
Victor Nogueira <hidden>
Date
2026-10-21 20:42:26
Also in
linux-kselftest
Reply to
Paolo Abeni, 2026-10-21
On Wed, Oct 21, 2026 at 11:22 AM Paolo Abeni [off-list ref] wrote:
On 10/19/26 23:39, netdev-bot+sashiko@kernel.org wrote:
quoted
Thank you for your contribution! Sashiko AI review found 3 potential
issue(s) to consider.

Critical: 0 · High: 0 (1) · Medium: 2 · Low: 1

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] drr_dequeue() and ets_qdisc_dequeue() allow only one bulk
   refill per dequeue: `scanned = true` is set at sch_drr.c:414 /…
This looks legit.

Also is would be great if you could somehow deduplicate the code a bit,
(but I have no good idea on how to achieve that)
Fair enough, I'll respin this set once net-next reopens.

cheers,
Victor
Thread (9 messages) 9 messages, 3 authors, last reply 25d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help