Thread (7 messages) 7 messages, 3 authors, 21h ago

[PATCH net 1/3] net/mlx5: HWS, Handle NULL in vport destination action creation

flat view
HOTtoday REVIEWED: 1 (0M)

From: Tariq Toukan <tariqt@nvidia.com>
Date: 2026-10-21 07:50:58
Also in: linux-rdma, lkml
Subsystem: mellanox mlx5 core vpi driver, networking drivers, the rest · Maintainers: Saeed Mahameed, Leon Romanovsky, Tariq Toukan, Mark Bloch, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

1 review trailer.

From: Yevgeny Kliteynik <redacted>

mlx5hws_action_create_dest_vport can return NULL - handle
this case before trying to insert NULL into xarray.

Fixes: 8e2e08a6d1e0 ("net/mlx5: fs, add support for dest vport HWS action")
Signed-off-by: Yevgeny Kliteynik <redacted>
Signed-off-by: Alex Vesker <redacted>
Reviewed-by: Erez Shitrit <redacted>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c | 3 +++
 1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
index 54761754e657..c4574c5f4ded 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/fs_hws.c
@@ -440,6 +440,9 @@ mlx5_fs_get_dest_action_vport(struct mlx5_fs_hws_context *fs_ctx,
 	dest = mlx5hws_action_create_dest_vport(ctx, vport_num,	vhca_id_valid,
 						dest_attr->vport.vhca_id, flags);
 
+	if (!dest)
+		return NULL;
+
 	err = xa_insert(dests_xa, idx, dest, GFP_KERNEL);
 	if (err) {
 		mlx5hws_action_destroy(dest);
-- 
2.44.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help