Re: [PATCH net-next v3 1/2] netlink: specs: add ovs_flow del and set operations

On Tue, 20 Oct 2026 16:24:40 -0400 Jakub Kicinski wrote:

Should include/uapi/linux/openvswitch.h get the same update?

Yes, the kernel-doc for OVS_FLOW_ATTR_KEY still says a key is required
for every request except a dump, and the kernel does not enforce that.
The header is a kernel change, so I will send it separately rather than
fold it into this series.

Could the doc mention those two cases as well?

Yes. A dump reads neither a key nor a ufid, and a del that carries
neither flushes the data path. The next version says both.

is "Always present in notifications" accurate?

It is not. A ufid-identified flow with OVS_UFID_F_OMIT_KEY set has no
key in the reply. The sentence was already in the spec and in the
header, and this patch only kept it. I will correct it with the header
change.

Should this change carry a tag like:
Fixes: 93b230b549bc ("netlink: specs: add ynl spec for ovs_flow")
Could it also go in a separate patch

I would rather keep it here. del and set both list probe, so splitting
the type fix out would leave them pointing at an attribute the spec
still encodes wrong. I have not added a Fixes tag for the same reason:
the change belongs with the operations that use the attribute.