Re: [PATCH AUTOSEL 6.18-5.10] sctp: auth: propagate HMAC calculation errors to callers

From
Xin Long <lucien.xin@gmail.com>
Date
2026-10-20 13:52:28
Also in
linux-patches, linux-sctp, lkml, stable
Reply to
Eric Biggers, 2026-10-19
On Mon, Oct 19, 2026 at 1:28 PM Eric Biggers [off-list ref] wrote:
On Mon, Oct 19, 2026 at 09:49:03AM -0400, Sasha Levin wrote:
quoted
- Residual in this tree: `crypto_shash_setkey()` failure still `goto
  free` without an error (mainline HMAC helpers no longer have that
  path). That is preexisting and outside this commit.
I don't think this backport can be considered complete without handling
that case.
Agreed. We should return the error from crypto_shash_setkey() when
it fails in sctp_auth_calculate_hmac().

Thanks.
Thread (34 messages) 34 messages, 3 authors, last reply 22d ago
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help