Thread (1 message) 1 message, 1 author, 8d ago

Re: [PATCH net-next v7 03/13] net: mana: keep per-queue statistics in the port context

From: Wei Hu <hidden>
Date: 2026-10-20 04:30:49
Also in: bpf, linux-hyperv, linux-rdma, sashiko-reviews

Hi,
In mana_remove(), unregister_netdevice() unlists the device but does not
synchronously wait for existing RCU grace periods to finish.
I will leave this ordering unchanged in v8. The premise does not match
the unregister path in the target tree.

unregister_netdevice() uses the NULL-head path, which performs unregister
work immediately. Before returning, that path unlists the device and
calls synchronize_net(), removes its sysfs exposure, and performs another
network grace period. mana_free_queue_stats() runs after that call.

Some final netdev processing is deferred to netdev_run_todo(), but the
grace periods relevant to the identified proc/sysfs readers are not all
deferred until rtnl_unlock(). The same ordering is present in the v6
counterpart and both upstream bases. The reported reader/free interleaving
therefore does not establish a UAF requiring a statistics-lifetime change.

Thanks,
Wei
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help