Re: [PATCH net-next v1 6/8] net: dsa: realtek: rtl8365mb: add QoS baseline and DCB default priority

[CC OpenWrt-devel to get some real-world usecase inputs]

On Mon, Oct 19, 2026 at 6:01 AM Luiz Angelo Daros de Luca
[off-list ref] wrote:

quoted

+       select NET_IEEE8021Q_HELPERS
+       select DCB

Is 'select DCB' really desired here? Drivers generally avoid
unconditionally selecting DCB because it pulls in a non-negligible
amount of netlink and QoS machinery into the kernel,

I'm not saying you're wrong, but the Microchip DSA switches
do select DCB for them all despite not all chips have this feature.

The argument to select it would be if the features are useful
for everyone.

I had an AI describe to me how the DCB features can be useful
for simple home routers running OpenWrt but I got a very
muddy answer :D I do not think a default OpenWrt
router userspace even uses the DCB features.

If this is just for datacenters and fancypants set-ups maybe
it would make sense to have it compile-out optional?

Arguably it is something OpenWrts default userspace
*should* be doing, even by default, since it's a well-known
and old feature present in many routers. I think they/we might
not have gotten there because we barely even embraced
DSA, such fancy stuff could be on the TODO list. In that
case, it may be helpful to have it default-enabled in the
DSA chips that support it so it can be rolled out.

Yours,
Linus Walleij