[PATCH net-next 3/4] net: pse-pd: si3474: use dev_err_probe() for controller registration
flat view
COOLING7d
From: Carlo Szelinsky <hidden>
Date: 2026-10-18 08:19:21
Also in:
lkml
Subsystem:
networking drivers, pse network driver, the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Oleksij Rempel, Kory Maincent, Linus Torvalds
The next patch makes devm_pse_controller_register() return -EPROBE_DEFER until a PI's vpwr supply is there. Use dev_err_probe(), as pd692x0 and tps23881 already do, so a deferral is not logged as an error on every retry. Signed-off-by: Carlo Szelinsky <redacted> --- drivers/net/pse-pd/si3474.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/pse-pd/si3474.c b/drivers/net/pse-pd/si3474.c
index 1845b9c51cf7..91800f39971f 100644
--- a/drivers/net/pse-pd/si3474.c
+++ b/drivers/net/pse-pd/si3474.c@@ -541,10 +541,9 @@ static int si3474_i2c_probe(struct i2c_client *client) priv->pcdev.nr_lines = SI3474_MAX_CHANS; ret = devm_pse_controller_register(dev, &priv->pcdev); - if (ret) { - dev_err(dev, "Failed to register PSE controller: 0x%x\n", ret); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, + "Failed to register PSE controller\n"); return 0; }
--
2.43.0