Re: [PATCH net-next v11 3/6] net: pcs: xpcs: add Rockchip RK3568 platform glue driver
flat view
From: Jakub Kicinski <kuba@kernel.org>
Date: 2026-10-16 23:37:23
Also in:
linux-arm-kernel, linux-devicetree, linux-rockchip, lkml
On Fri, 9 Oct 2026 01:51:57 +0800 Coia Prant wrote:
quoted hunk ↗ jump to hunk
+config PCS_XPCS_PLATFORM + tristate "Generic XPCS controller support" + default PCS_XPCS
Why the default? Surely there are platforms with PCS_XPCS enabled which work today == don't care about the new code? Linus is known to hate _any_ new symbols defaulting to enabled on olddefconfig.
quoted hunk ↗ jump to hunk
+ help + Generic DWXPCS driver for platforms that don't require any + platform specific code to function or is using platform + data for setup. + + If you have a controller with this interface, say Y or M here. + +config PCS_XPCS_ROCKCHIP + tristate "Rockchip XPCS controller support" + default ARCH_ROCKCHIP
Same here.
quoted hunk ↗ jump to hunk
+ depends on OF && (ARCH_ROCKCHIP || COMPILE_TEST) + select GENERIC_PHY + select PM_GENERIC_DOMAINS if PM + help + Support for XPCS controller on Rockchip RK356x SoC. + + If you have a Rockchip SoC with this interface, say Y or M here.
-- pw-bot: cr