Thread (39 messages) 39 messages, 6 authors, 6d ago

Re: [PATCH net-next v2 2/7] um: vector: honor virtio net hdr conversion failures

flat view

From: "Michael S. Tsirkin" <mst@redhat.com>
Date: 2026-10-16 09:53:59
Also in: linux-um, lkml, virtualization

On Fri, Oct 16, 2026 at 11:49:14AM +0200, Johannes Berg wrote:
On Fri, 2026-10-16 at 05:47 -0400, Michael S. Tsirkin wrote:
quoted
quoted
quoted
Right, but virtio_net_hdr_to_skb() cannot return 1, only 0 on success
and -ERROR on failure?
After this patchset, it can, to signal slow path software checksum.
I'm changing callers first so that changing the function itself
does not break bisect. I should mention this in the commit log.
Oh, OK, that I clearly missed, but also was only CC'ed on patches 2 and
3 :)

johannes
Right, I am trying not to spam too widely.
Indeed, this is why commit log should explain.

-- 
MST
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help