Re: [PATCH net-next v2 1/2] netlink: specs: add ovs_flow del and set operations

On Tue, 13 Oct 2026, netdev-bot+sashiko@kernel.org wrote:

[Medium] The new operation's request list still leaves out ufid-flags
and probe. ovs_flow_cmd_new() reads both.

Yes. ovs_flow_cmd_new() reads OVS_FLOW_ATTR_UFID_FLAGS and
OVS_FLOW_ATTR_PROBE, and the del and set lists in this patch already
have them. The new list did not. v3 adds both.

[Low] The commit message does not mention the probe type change or the
uns-admin-perm flag added to the existing new operation.

Right, it only said del and set need CAP_NET_ADMIN. new takes the same
flag, and probe changes from binary to flag, which changes how a YNL
client encodes it. v3 says both.

[Low] The key attribute doc says a key is required for every request
except a dump, which contradicts the new del and set docs.

The doc was wrong. get, set and del all accept a ufid with no key, and
only a new flow needs one. A set that replaces the actions still needs
a key, which the set doc already says. v3 changes the key doc.

[Low] The get operation uses one request list for both do and dump.

That list predates this series. get's do request reads probe and the
dump request only reads ufid-flags, so the two should not share a list.
I am leaving it for a separate patch rather than widening this one.

pw-bot: cr