Thread (27 messages) 27 messages, 7 authors, 2d ago

Re: [PATCH net 07/10] net: ethoc: move setting of netops to fix crash

flat view

From: Daniel Machon <daniel.machon@microchip.com>
Date: 2026-10-13 10:00:59
Also in: lkml

ethoc_probe() calls ethoc_mdio_probe(), which connects the PHY,
before netdev->netdev_ops is assigned. phy_attach_direct() ->
phy_link_topo_add_phy() reads dev->netdev_ops through
netdev_need_ops_lock() since the commit in question, so probing crashes
with a NULL pointer dereference when CONFIG_NET_SHAPER is enabled.

Assign netdev_ops before the PHY attach, as was done for emac in commit
7c9f391ec89c ("net: emac: move setting of netops to fix crash").
Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help