Thread (13 messages) 13 messages, 3 authors, 11d ago

Re: [PATCH v1 net-next 0/4] neighbour: Misc follow-ups on per-netns neigh_table series.

flat view

From: Kuniyuki Iwashima <kuniyu@google.com>
Date: 2026-10-13 07:24:06

On Tue, Oct 13, 2026 at 12:00 AM Ido Schimmel [off-list ref] wrote:
On Mon, Oct 12, 2026 at 07:44:55PM +0000, Kuniyuki Iwashima wrote:
quoted
Patch 1 updates the switchdev doc, s/arp_tbl/arp_table(net)/.

Patch 2 updates a selftest for per-netns sysctl knobs, though this
is not an actual issue since the test does not hit gc_thresh by
default.

Patches 3 & 4 are based on a suggestion by Ido Schimmel to make
neigh_managed_work CPU-friendly:

  https://lore.kernel.org/netdev/20260902143023.GA3966681@shredder/ (local)
Thanks for the follow-up, but I think you missed my first point...
Oops, sorry I seem to have been sidetracked by 6d79b223ec44 series...
My
comment was about the GC work that doesn't have a floor at all. An
unprivileged user can set the base reachable time to 0 and
neigh_periodic_work() will hog the CPU.
I'll add the max(HZ, ...) change in patch 5.

---
pw-bot: cr


quoted
Given it's rc7, I'll defer RTNL removal to the next cycle.


Kuniyuki Iwashima (4):
  Documentation: networking: switchdev: Replace arp_tbl with
    arp_table(net).
  selftests: netfilter: Set gc_thresh[123] for gw netns in
    nft_nat_zones.sh.
  neighbour: Schedule neigh_managed_work only when needed.
  neighbour: Floor INTERVAL_PROBE_TIME_MS at 1000.

 Documentation/netlink/specs/rt-neigh.yaml     |  2 +-
 Documentation/networking/ip-sysctl.rst        |  2 +-
 Documentation/networking/switchdev.rst        | 11 +++---
 net/core/neighbour.c                          | 26 ++++++++++----
 .../selftests/net/netfilter/nft_nat_zones.sh  | 34 +++++--------------
 5 files changed, 35 insertions(+), 40 deletions(-)

--
2.56.0.385.gd3acb90ef8-goog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help