Re: [PATCH net-next v8 4/8] hsr: Drop received PTP packets
flat view
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Date: 2026-10-12 14:49:06
On 2026-10-06 14:31:17 [+0000], netdev-bot+sashiko@kernel.org wrote:
[Severity: Medium]
The commit message says:
Drop all received PTP packets.
Do these checks catch PTP carried over UDP? Both branches only match
ETH_P_1588, which is the Layer 2 mapping.
PTP over UDP/IPv4 or IPv6 (ports 319/320) has ETH_P_IP or ETH_P_IPV6 in…
UDP PTP behaves the same as it did before this patch, and the IEC 62439-3 PTP profile for HSR/PRP uses the L2 mapping. Still, the commit message names only VLAN-tagged packets as out of scope. The new comment also states the policy for PTP in general. Should the commit message and the comment say that only L2 (ETH_P_1588) PTP is dropped? Or should the UDP case be handled as well?
The HSR/PRP specification mentions only L2 therefore the checks focus here on L2. Using HSR and PTP with L3 transport such as UDPv4 is outside the specification (or PTP profile). I don't think it makes sense to mention this or check for this case. Sebastian