Thread (3 messages) 3 messages, 2 authors, 1d ago

Re: [PATCH net v3] vlan: restore HW VLAN tag insertion with reorder_hdr off

flat view

From: Jan Čermák <hidden>
Date: 2026-10-12 12:11:03

Hi Eric,

as I wrote in [1], the bug also affected cards using the r8152 driver,
so I used that in my setup for testing.

I applied this patch to v6.18.54, which was previously used as base
for testing, and I confirm the issue is gone, and the VLAN interface
can be normally used. On vanilla v6.18.54 toggling reorder_hdr to off
triggered the issue (even when the VLAN was created with it enabled),
so this step was enough to verify the regression is mitigated
kernel-side, so:

Tested-by: Jan Čermák <redacted>

Previous v2 of the patch was confirmed to fix the issue with r8169 as
well by hitchin999 in [2].

Thanks for looking into that!

Cheers,
Jan

[1] https://lore.kernel.org/netdev/CAPa5EdD7tFRyDztEanTwQXTzVEE8T0FLkbXAtWxUcGGaLYt_bA@mail.gmail.com/ (local)
[2] https://github.com/home-assistant/operating-system/issues/5019#issuecomment-6065756866
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help