Thread (4 messages) 4 messages, 3 authors, 3d ago

Re: [PATCH net v1] net: devmem: prevent mixing fragments from different bindings

flat view

From: Mina Almasry <hidden>
Date: 2026-10-11 15:46:10
Also in: lkml

On Sun, Oct 11, 2026 at 8:00 AM [off-list ref] wrote:
Thank you for your contribution! Sashiko AI review found 2 potential
issue(s) to consider.

Critical: 0 · High: 2 (1) · Medium: 0 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [High] This patch makes a valid devmem MSG_ZEROCOPY sendmsg() fail with
  -EFAULT.
- [High] The commit says it prevents mixing fragments from different
  devmem bindings in one skb, but it only guards the…

Pre-existing issues:
- [High] This problem wasn't introduced by this patch, but it undermines
  the validation the patch hardens.
Both these issues seem valid. I could fix them in follow up patches
but it may be good to try to fix them now. Let me take a stab at it.

pw-bot: cr

-- 
Thanks,
Mina
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help