Thread (4 messages) 4 messages, 3 authors, 11d ago

[PATCH net-next v2] net: phy: marvell: add LED support for 88E1116R PHY

flat view
COOLING11d LANDED

From: Konstantin Meshkov <hidden>
Date: 2026-10-10 18:35:41
Also in: lkml
Subsystem: ethernet phy library, networking drivers, the rest · Maintainers: Andrew Lunn, Heiner Kallweit, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

Status: Landed in mainline as ce7db1caaa68 on 2026-10-16.

The Marvell 88E1116R PHY (used on the D-Link DNS-325) exposes its LEDs
through the same page 3 register 0x10 LED control layout as the 88E1318S.
Wire up the existing 88E1318S LED handlers in the 88E1116R driver entry
so the PHY LEDs can be described in the device tree and driven through
the LED trigger API with hardware offload.

Tested on a D-Link DNS-325 (88E1116R): both PHY LEDs are registered and
hardware-offloaded.

Signed-off-by: Konstantin Meshkov <redacted>
---
Changes in v2:
- Only wire up the LED trigger handlers; drop the led_polarity_set
  assignment and the dependency on the pending PHY LED polarity
  series, as suggested by Aleksander Jan Bajkowski. LED polarity
  for the 88E1116R will be handled there.
- Rebased on current net-next.
- Cc the netdev maintainers.
v1: https://lore.kernel.org/netdev/179152610952.2918676.6625057760354797023@mail.ru/ (local)

 drivers/net/phy/marvell.c | 5 +++++
 1 file changed, 5 insertions(+)
diff --git a/drivers/net/phy/marvell.c b/drivers/net/phy/marvell.c
index f71cffa..244454f 100644
--- a/drivers/net/phy/marvell.c
+++ b/drivers/net/phy/marvell.c
@@ -3913,6 +3913,11 @@ static struct phy_driver marvell_drivers[] = {
 		.get_stats = marvell_get_stats,
 		.get_tunable = m88e1011_get_tunable,
 		.set_tunable = m88e1011_set_tunable,
+		.led_brightness_set = m88e1318_led_brightness_set,
+		.led_blink_set = m88e1318_led_blink_set,
+		.led_hw_is_supported = m88e1318_led_hw_is_supported,
+		.led_hw_control_set = m88e1318_led_hw_control_set,
+		.led_hw_control_get = m88e1318_led_hw_control_get,
 	},
 	{
 		.phy_id = MARVELL_PHY_ID_88E1510,
-- 
2.39.5
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help