Re: [PATCH net-next 18/37] dt-bindings: net: can: convert grcan to DT schema
flat view
From: netdev-bot+sashiko@kernel.org
Date: 2026-10-10 14:02:59
Also in:
linux-can
Thank you for your contribution! Sashiko AI review found more severe issue(s) in other patches of this series. This mail is only an FYI, in case you want to address the nit picks below when you respin. Low priority / nit picks for your consideration: - [Low] Commit "dt-bindings: net: can: convert grcan to DT schema" deletes Documentation/devicetree/bindings/net/can/grcan.txt, but the… -- dt-bindings: net: can: convert grcan to DT schema This converts the free-form grcan.txt binding to a YAML DT schema. Because these nodes have no compatible string, the schema selects them by node name. The text file is then deleted. Link: https://patch.msgid.link/20260929073703.2748220-2-quchaosheng000406@163.com (local) [ ... ]
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/net/can/grcan.txt b/Documentation/devicetree/bindings/net/can/grcan.txt deleted file mode 100644 index 34ef3498f8870..0000000000000 --- a/Documentation/devicetree/bindings/net/can/grcan.txt +++ /dev/null@@ -1,28 +0,0 @@ -Aeroflex Gaisler GRCAN and GRHCAN CAN controllers.
[ ... ] [Severity: Low] After this commit, the file header comment in drivers/net/can/grcan.c still points to the file being deleted here: drivers/net/can/grcan.c: * See "Documentation/devicetree/bindings/net/can/grcan.txt" for information on * open firmware properties. Would scripts/documentation-file-ref-check report this as a broken reference at this commit? The commit message says "The driver comment is updated by a separate patch." A later commit in the same series, "can: grcan: update the binding file reference in the driver comment", changes the comment to point to aeroflexgaisler,grcan.yaml. So the stale reference only shows up when this commit is bisected to or backported on its own. Could the comment update be folded into this patch, or ordered before it? That would keep the reference valid at every point in the series. -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261009134323.64064-2-mkl%40pengutronix.de