Re: [PATCH net-next v1 0/6] net: unify symmetric netmem and page_pool refcounting
flat view
From: Mina Almasry <hidden>
Date: 2026-10-10 08:51:30
Also in:
bpf, linux-rdma, lkml
On Sat, Oct 10, 2026 at 1:45 AM [off-list ref] wrote:
Hi! This is an automated message. This series looks like a fix, but its commit messages seem to be missing some information: - How the issue was discovered, e.g. hit in production, hit during development, syzbot report, manual code inspection, LLM or static analysis tool scan. - Whether the issue was actually triggered, or is only theoretical (e.g. found by code inspection). If it was triggered please include the symptoms, like the stack trace or error messages. - What hardware the change was tested on. For driver fixes please mention the device (and if relevant firmware version) used for testing, or say that the change was not tested on real hardware. Please do not repost the series just to address the above. Instead, reply to this email with the missing information, so that reviewers can take it into account. If the series needs another revision for other reasons, please include the information in the commit messages then. The evaluation is done by an LLM so it may be wrong, if you think that is the case please reply and explain.
I was reminded what I complicated mess skb frag accounting currently is when I looked at this patch: [1] https://lore.kernel.org/netdev/xfrm-iptfs-pp_ref_count-underflow-v4-1-912fa72106f0@secunet.com/ (local) And saw that the author was trying to write their own skb frag helper inside the driver because core didn't provide one that made sense :/ code inspection + LLM written tests for accounting confirmed the issues. I worked with the LLM to fix the discovered issues. Not hit in production or reproduced organically. Only code inspection and artificial tests. -- Thanks, Mina