[PATCH net-next v3 2/4] net: dsa: motorcomm: Use NSEC_PER_SEC
flat view
HOTtoday
IN NET-NEXT: 8 (8M)
From: David Yang <mmyangfl@gmail.com>
Date: 2026-10-09 16:58:49
Also in:
lkml
Subsystem:
networking drivers, networking [dsa], the rest · Maintainers:
Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Andrew Lunn, Vladimir Oltean, Linus Torvalds
Revision v3 of 3 in this series; 1 review trailer (1 from subsystem maintainers); queued in net-next as 4a8e05d62ecc on 2026-10-17.
Revisions (3)
- v1 [diff vs current]
- v2 [diff vs current]
- v3 current
Get rid of magic numbers. Signed-off-by: David Yang <mmyangfl@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/dsa/motorcomm/tc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/dsa/motorcomm/tc.c b/drivers/net/dsa/motorcomm/tc.c
index 433a428ed070..be3321df8868 100644
--- a/drivers/net/dsa/motorcomm/tc.c
+++ b/drivers/net/dsa/motorcomm/tc.c@@ -25,14 +25,14 @@ static u32 rate2token(u64 rate, unsigned int slot_ns, int unit, int C) { int e = 2 * unit + C + YT921X_TOKEN_RATE_C; - return div_u64(ldexpu64(slot_ns * rate, -e), 1000000000); + return div_u64(ldexpu64(slot_ns * rate, -e), NSEC_PER_SEC); } static u64 token2rate(u32 token, unsigned int slot_ns, int unit, int C) { int e = 2 * unit + C + YT921X_TOKEN_RATE_C; - return div_u64(ldexpu64(mul_u32_u32(1000000000, token), e), slot_ns); + return div_u64(ldexpu64(mul_u32_u32(NSEC_PER_SEC, token), e), slot_ns); } /* burst = 2^C * token * 4^unit */
@@ -83,7 +83,7 @@ yt921x_marker_tfm(struct yt921x_marker *marker, u64 rate, u64 burst, } /* Check for matching burst */ - burst_est = div_u64(slot_ns * rate, 1000000000); + burst_est = div_u64(slot_ns * rate, NSEC_PER_SEC); burst_sug = burst_est; if (flags & YT921X_MARKER_PKT_MODE) burst_sug++;
--
2.53.0