[PATCH net-next v9 07/11] net: phy: ncn26000: Enable enhanced noise immunity
flat view
COOLING6d
REVIEWED: 8 (8M)
From: Selvamani Rajagopal via B4 Relay <devnull+Selvamani.Rajagopal.onsemi.com@kernel.org>
Date: 2026-10-09 17:12:26
Also in:
b4-sent, linux-devicetree, linux-doc, lkml
Subsystem:
ethernet phy library, networking drivers, onsemi ethernet phy drivers, the rest · Maintainers:
Andrew Lunn, Heiner Kallweit, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Piergiorgio Beruto, Linus Torvalds
Revision v9 of 4 in this series; 1 review trailer (1 from subsystem maintainers).
Revisions (4)
- v4 [diff vs current]
- v6 [diff vs current]
- v8 [diff vs current]
- v9 current
From: Selvamani Rajagopal <redacted> By setting ENI bit, noise immunity is improved and it is specifically meant for PLCA enabled nodes. Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Selvamani Rajagopal <redacted> --- changes in v9 - Added Reviewed tag changes in v8 - No change changes in v7 - No change changes in v6 - No change changes in v5 - No changes changes in v4 - No changes changes in v3 - Moved as a separate patch --- drivers/net/phy/ncn26000.c | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/ncn26000.c b/drivers/net/phy/ncn26000.c
index cabdd83c614f..6d433f4e2c45 100644
--- a/drivers/net/phy/ncn26000.c
+++ b/drivers/net/phy/ncn26000.c@@ -35,6 +35,10 @@ #define TO_TMR_DEFAULT 32 +#define NCN26000_REG_PHYCFG1 0x8001 +#define NCN26000_PHYCFG1_ENI BIT(7) +#define NCN26000_PHYCFG1_ENI_MASK BIT(7) + static int ncn26000_config_init(struct phy_device *phydev) { /* HW bug workaround: the default value of the PLCA TO_TIMER should be
@@ -100,6 +104,24 @@ static int ncn26000_read_status(struct phy_device *phydev) return 0; } +/* Intercept PLCA enable/disable request to + * set the proprietary, ENI mode accordingly + */ +static int ncn26000_c45_plca_set_cfg(struct phy_device *phydev, + const struct phy_plca_cfg *plca_cfg) +{ + int ret = genphy_c45_plca_set_cfg(phydev, plca_cfg); + u16 eni_cfg = 0; + + if (ret || plca_cfg->enabled < 0) + return ret; + + eni_cfg = (plca_cfg->enabled) ? NCN26000_PHYCFG1_ENI : 0; + return phy_modify_mmd(phydev, MDIO_MMD_VEND2, + NCN26000_REG_PHYCFG1, + NCN26000_PHYCFG1_ENI_MASK, eni_cfg); +} + static irqreturn_t ncn26000_handle_interrupt(struct phy_device *phydev) { int ret;
@@ -151,7 +173,7 @@ static struct phy_driver ncn26000_driver[] = { .read_status = ncn26000_read_status, .handle_interrupt = ncn26000_handle_interrupt, .get_plca_cfg = genphy_c45_plca_get_cfg, - .set_plca_cfg = genphy_c45_plca_set_cfg, + .set_plca_cfg = ncn26000_c45_plca_set_cfg, .get_plca_status = genphy_c45_plca_get_status, .soft_reset = genphy_soft_reset, },
--
2.43.0