Thread (7 messages) 7 messages, 4 authors, 13d ago

Re: [PATCH net-next v5] net/sched: cap the accounted backlog before it can wrap

flat view

From: Stephen Hemminger <stephen@networkplumber.org>
Date: 2026-10-08 15:23:49

On Thu, 08 Oct 2026 14:54:08 +0200
Toke Høiland-Jørgensen [off-list ref] wrote:
quoted
quoted
 
quoted
+/* Compute the flow/host hash keys from the packet as received. Must run
+ * before skb_gso_segment(), which rewrites an encapsulated GSO packet's
+ * headers to the inner ones and would change the keys. Reads only the skb
+ * and commits no qdisc state, so it may run before admission is known.
+ */  
And drop the weird LLM comments, please. If you split the series
properly they are not needed.
 
Like I said, it's a dilemma.  
See above.
As heavy LLM user, I often have to tell it.
"Thats good, now rewrite the commit and comments for humans. Make the result
 conform to the style of other places in the same code"
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help