RE: [PATCH net v2 1/3] net: libwx: keep NGBE OCP cards MAC enabled
flat view
From: Jiawen Wu <jiawenwu@trustnetic.com>
Date: 2026-10-08 02:19:40
On Wed, Sep 30, 2026 9:49 AM, Jakub Kicinski wrote:
On Thu, 24 Sep 2026 10:01:47 +0800 Jiawen Wu wrote:quoted
if (!(((wx->subsystem_device_id & WX_NCSI_MASK) == WX_NCSI_SUP) || - ((wx->subsystem_device_id & WX_WOL_MASK) == WX_WOL_SUP))) { + ((wx->subsystem_device_id & WX_WOL_MASK) == WX_WOL_SUP) || + (wx->mac.type == wx_mac_em && (wx->subsystem_device_id & 0xFF) == 0x40))) {This condition looks way too magical for upstream Add some wx_has_ncsi() helper and add it there? At least then the meaning is clear, here it's next to WOL, no idea what it's supposed to mean.
I had planned to fix this issue temporarily, and unify to use 'wx->ncsi_enabled' in a later net-next patch. Looks like I'm messing things up. I'll fix it all in V3.