Thread (28 messages) 28 messages, 7 authors, 6d ago

Re: [PATCH 16/17] rcu: assert static storage for RCU sync and SRCU definitions

flat view

From: Joel Fernandes <joelagnelf@nvidia.com>
Date: 2026-10-07 18:58:19
Also in: linux-fsdevel, linux-mm, linux-rt-devel, linuxppc-dev, lkml, llvm, rcu, virtualization


On 10/7/2026 2:48 PM, Yury Norov wrote:
On Wed, Oct 07, 2026 at 02:41:05PM -0400, Joel Fernandes wrote:
quoted
On Mon, Sep 14, 2026 at 11:13:31PM -0400, Yury Norov wrote:
quoted
DEFINE_RCU_SYNC() contains a statically initialized wait queue. SRCU
static definitions similarly rely on persistent lockdep keys and, in
Tiny SRCU, a statically initialized work item.

Add ASSERT_STATIC_STORAGE() to DEFINE_RCU_SYNC(), both Tree SRCU
__DEFINE_SRCU() variants and Tiny SRCU's common DEFINE_SRCU() declaration.
This covers the non-static FAST and FAST_UPDOWN wrappers too. Tiny SRCU's
explicitly static declarations already enforce the required duration.
The existing per-CPU restrictions on Tree SRCU declarations still apply.

Assisted-by: OpenAI Codex
Signed-off-by: Yury Norov <redacted>
All the changes make sense to me. I'm ok with carrying this for -rcu 7.5
unless you want to take it.

Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com>
Thanks Joel, carrying it with the RCU branch is the preferred route IMO.
Ok, applying this patch for -rcu 7.5, thanks!

thanks,

Joel Fernandes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help