Re: [PATCH v2 net-next 0/9] neighbour: Add IPv4/IPv6-specific wrappers for neigh_lookup() and friends.

From
Ido Schimmel <idosch@nvidia.com>
Date
2026-10-07 16:50:17
Reply to
Jakub Kicinski, 2026-10-07
On Wed, Oct 07, 2026 at 09:35:55AM -0700, Jakub Kicinski wrote:
On Sat,  3 Oct 2026 21:23:13 +0000 Kuniyuki Iwashima wrote:
quoted
syzbot reported that ip6_finish_output2() could pass tbl and dev
from different netns to neigh_create().

When namespacifying neigh_table, I chose to resolve neigh_table
in callers to minimise changes, but it turned out to be error-prone.

This series adds IPv4/IPv6-specific helpers for neigh_lookup()
and neigh_create() that always fetch the netns from dev to fix
the problem.

Along the way, the confusing and now mostly redundant helpers
__neigh_lookup() and __neigh_lookup_errno() are converted and
removed.
Ido, David, thoughts?
The unusual (for Ido) silence makes me suspicious :)
Too many other patches to review...

The series looks good to me:

Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Thread (18 messages) 18 messages, 5 authors, last reply 2026-10-07
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help