[PATCH net-next 0/2] netlink: specs: fill in the missing ovs operations
flat view
HOTtoday
From: Minxi Hou <hidden>
Date: 2026-10-06 13:06:01
The ovs datapath, vport and flow specs describe families the kernel has shipped for a long time, but each one stops short of the write commands. ovs_flow has get and new only. The datapath and vport specs have no set. Nothing in the tree generates code from these files. A YNL client only hits the gap when it tries to send the command. Name the missing operations and the attributes the kernel handlers read. del and set on ovs_flow, set on ovs_datapath and ovs_vport. The handlers take CAP_NET_ADMIN through GENL_UNS_ADMIN_PERM, and so do the new and del commands that were already in the specs. Mark all nine write operations uns-admin-perm. get stays open. Two requests are rejected for reasons the attribute list cannot say. Flow set returns -EINVAL when it carries neither a key nor a ufid. Datapath set treats a missing user-features attribute as zero, so it clears whatever was set before. Both are in the operation doc. The new, del and set handlers fill a reply, but they send it with ovs_notify() to the multicast group. The caller gets an ack, not those attributes, so the specs do not list a reply for them. get does, and it returns the attributes to the caller. Checked against a live kernel: flow set and delete, a delete with no key that flushes the data path, a datapath set of the masks cache size that also clears user features, and a vport set of the upcall pid. A vport set that changes the type returns -EINVAL, as the handler does. Signed-off-by: Minxi Hou <redacted> --- Minxi Hou (2): netlink: specs: add ovs_flow del and set operations netlink: specs: add ovs datapath and vport set operations Documentation/netlink/specs/ovs_datapath.yaml | 18 ++++++++++++ Documentation/netlink/specs/ovs_flow.yaml | 31 +++++++++++++++++++++ Documentation/netlink/specs/ovs_vport.yaml | 15 ++++++++++ 3 files changed, 64 insertions(+) base-commit: a5e7d8e446af9803e37a3b6a4d416fb41178348f -- 2.55.0