Re: [PATCH net] ptp: vclock: reject failed physical clock samples
flat view
From: James Hilliard <hidden>
Date: 2026-10-06 04:41:11
Also in:
lkml
On Wed, Sep 30, 2026 at 11:39 PM [off-list ref] wrote:
Hi! This is an automated message. This series looks like a fix, but its commit messages seem to be missing some information: - How the issue was discovered, e.g. hit in production, hit during development, syzbot report, manual code inspection, LLM or static analysis tool scan.
Found by tracing PHC read-error handling while working on the larger stmmac MTU/resume recovery series. Related cleanup issues were found during follow-up review.
- Whether the issue was actually triggered, or is only theoretical (e.g. found by code inspection). If it was triggered please include the symptoms, like the stack trace or error messages.
The failure handling was checked in host tests, including reproduction of the partial-registration cleanup problem. I have not reproduced a clock jump or teardown hang with a real PHC in a running kernel.
Please do not repost the series just to address the above. Instead, reply to this email with the missing information, so that reviewers can take it into account. If the series needs another revision for other reasons, please include the information in the commit messages then. The evaluation is done by an LLM so it may be wrong, if you think that is the case please reply and explain.