Thread (9 messages) 9 messages, 4 authors, 12d ago

[PATCH net 3/4] bnge: do not fail open if IRQ affinity hint fails

flat view
COOLING12d IN NET-NEXT: 3 (0M)

From: Bhargava Marreddy <hidden>
Date: 2026-10-05 12:18:53
Also in: lkml
Subsystem: broadcom bng_en 800 gigabit ethernet driver, networking drivers, the rest · Maintainers: Vikas Gupta, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds

3 review trailers; queued in net-next as dc9a69f4d853 on 2026-10-07.

IRQ affinity hints are advisory and not fatal to driver operations.
On uniprocessor builds (CONFIG_SMP=n), irq_set_affinity_hint() always
returns -EINVAL, which currently prevents ndo_open() from succeeding.

Log a warning and continue instead of failing open on affinity error.

Fixes: bd06d729722e ("bng_en: Add initial support for CP and NQ rings")
Signed-off-by: Bhargava Marreddy <redacted>
Reviewed-by: Dharmender Garg <redacted>
Reviewed-by: Rajashekar Hudumula <redacted>
Reviewed-by: Ramakrishna Koduri <redacted>
---
 drivers/net/ethernet/broadcom/bnge/bnge_netdev.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
index bf101eded3bf..ca14d13fa3e9 100644
--- a/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
+++ b/drivers/net/ethernet/broadcom/bnge/bnge_netdev.c
@@ -2666,12 +2666,10 @@ static int bnge_request_irq(struct bnge_net *bn)
 			irq->have_cpumask = 1;
 			cpumask_set_cpu(cpumask_local_spread(i, numa_node),
 					irq->cpu_mask);
-			rc = irq_set_affinity_hint(irq->vector, irq->cpu_mask);
-			if (rc) {
+			if (irq_set_affinity_hint(irq->vector, irq->cpu_mask)) {
 				netdev_warn(bn->netdev,
 					    "Set affinity failed, IRQ = %d\n",
 					    irq->vector);
-				goto err_free_irq;
 			}
 		}
 	}
-- 
2.47.3
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help