[PATCH net-next v5 4/5] net: mdio: realtek-rtl9300: reject duplicate MDIO bus IDs
flat view
COOLING6d
IN NET-NEXT: 8 (8M)
From: Markus Stockhausen <hidden>
Date: 2026-10-05 07:49:27
Also in:
linux-devicetree
Subsystem:
ethernet phy library, networking drivers, the rest · Maintainers:
Andrew Lunn, Heiner Kallweit, Andrew Lunn, "David S. Miller", Eric Dumazet, Jakub Kicinski, Paolo Abeni, Linus Torvalds
Revision v5 of 3 in this series; 1 review trailer (1 from subsystem maintainers); queued in net-next as 808c15994074 on 2026-10-08.
Revisions (3)
- v3 [diff vs current]
- v4 [diff vs current]
- v5 current
The reg property identifies the hardware MDIO bus and is used as an index into the per-bus state. However, duplicate bus IDs are currently not rejected explicitly and only fail later during MDIO bus registration due to the duplicate bus ID. Keep track of successfully registered buses and reject a duplicate reg value before allocating another bus. For this use the already existing but currently unused priv->bus[] property. Signed-off-by: Markus Stockhausen <redacted> Reviewed-by: Andrew Lunn <andrew@lunn.ch> --- drivers/net/mdio/mdio-realtek-rtl9300.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/drivers/net/mdio/mdio-realtek-rtl9300.c b/drivers/net/mdio/mdio-realtek-rtl9300.c
index 79422893cc85..63ffb7f82b98 100644
--- a/drivers/net/mdio/mdio-realtek-rtl9300.c
+++ b/drivers/net/mdio/mdio-realtek-rtl9300.c@@ -851,6 +851,9 @@ static int otto_emdio_probe_one(struct device *dev, struct otto_emdio_priv *priv return dev_err_probe(dev, -EINVAL, "illegal (dangling) smi bus number %d\n", mdio_bus); + if (priv->bus[mdio_bus]) + return dev_err_probe(dev, -EINVAL, "duplicated smi bus number %d\n", mdio_bus); + bus = devm_mdiobus_alloc_size(dev, sizeof(*chan)); if (!bus) return -ENOMEM;
@@ -874,6 +877,8 @@ static int otto_emdio_probe_one(struct device *dev, struct otto_emdio_priv *priv if (err) return dev_err_probe(dev, err, "cannot register MDIO bus\n"); + priv->bus[mdio_bus] = bus; + return 0; }
--
2.55.0