Thread (4 messages) 4 messages, 3 authors, 3d ago

Re: [PATCH net-next] tun: use pskb_may_pull_reason() and remove SKB_DROP_REASON_HDR_TRUNC

flat view

From: Anton Danilov <hidden>
Date: 2026-10-03 13:22:01
Also in: lkml

On Thu, Oct 01, 2026 at 03:00:37PM -0400, Willem de Bruijn wrote:
Anton Danilov wrote:
quoted
 	case IFF_TAP:
-		if (!pskb_may_pull(skb, ETH_HLEN)) {
+		drop_reason = pskb_may_pull_reason(skb, ETH_HLEN);
Should we update the skb_may_pull in the above IFF_TUN similarly?
I left it out because that pull never used HDR_TRUNC, so converting it
is a separate change: its drop is reported as NOT_SPECIFIED today, and
with pskb_may_pull_reason() it becomes PKT_TOO_SMALL.

I will convert it in v2.

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help