Thread (4 messages) 4 messages, 2 authors, 1d ago

[PATCH net v3 0/2] eth: fbnic: Queue and channel count fixes

flat view
WARM1d

From: Björn Töpel <bjorn@kernel.org>
Date: 2026-10-02 12:56:24
Also in: lkml

Two fixes for what fbnic tells the core about its queues.

Patch 1 keeps the channel layout across suspend. Resume rebuilt it
from the queue counts, turning standalone channels into combined ones
or dropping combined queues, even with an unchanged IRQ count.

Patch 2 publishes the real queue counts at probe and on "ethtool -L"
while down, instead of at the next open.

Resume with fewer IRQs than the layout needs now fails instead of
shrinking the layout. That case is left for a separate change.

Changes in v3:
- Split into two patches, one per bug, each blaming the commit that
  introduced it.
- Keep num_napi across suspend instead of a separate num_napi_cfg.
- Drop the -ENOSPC check on resume, so an interface that is down no
  longer fails resume. (Breno, Sashiko)
- Skip ndo_stop when no NAPI vectors are allocated.
- Drop Breno's Reviewed-by, since the resume path changed.

Changes in v2:
- Keep the configured NAPI count and restore it on resume. v1
  recomputed it from the queue counts, which changed dedicated rx and
  tx layouts even when the vector count was unchanged. (Breno,
  Sashiko)
- Fail resume with -ENOSPC when fewer vectors come back than the
  configured layout needs. (Sashiko)
- Fix the comment and commit message that did not match the code.
  (Breno, Sashiko)
- Keep the RSS indirection reset in fbnic_netdev_alloc().
- Drop Breno's Reviewed-by, since the resume path changed.

v2: https://lore.kernel.org/netdev/20260924191817.1843726-1-bjorn@kernel.org/ (local)
v1: https://lore.kernel.org/netdev/20260915180859.4157646-1-bjorn@kernel.org/ (local)

Björn Töpel (2):
  eth: fbnic: Preserve channels across resume
  eth: fbnic: Publish real queue counts

 .../net/ethernet/meta/fbnic/fbnic_ethtool.c   |  7 ++++
 .../net/ethernet/meta/fbnic/fbnic_netdev.c    | 36 ++++++++++++++-----
 .../net/ethernet/meta/fbnic/fbnic_netdev.h    |  3 --
 drivers/net/ethernet/meta/fbnic/fbnic_pci.c   |  9 -----
 4 files changed, 34 insertions(+), 21 deletions(-)


base-commit: 71a77ab76e74131a101f4d2d2afb0dcbf81b4e3c
-- 
2.55.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help