Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The new file net/ipv4/raw_ipv4.c exports raw_v4_match() with
EXPORT_SYMBOL_GPL(raw_v4_match) at line 60, but it never includes…
- [Low] The move is incomplete and leaves dead code in net/ipv4/raw.c.
--
ipv4: raw: split IPv4 specific logic into raw_ipv4.c
This commit moves the IPv4 specific RAW socket code out of raw.c and into
a new file, net/ipv4/raw_ipv4.c. That covers packet matching,
input/output processing, ICMP filtering and the AF_INET raw_prot
definition. raw_ipv4.c is built only with CONFIG_IPV4, and raw_lookup()
in raw_diag.c now guards raw_v4_match() with IS_ENABLED(CONFIG_IPV4).
quoted hunk ↗ jump to hunk
diff --git a/net/ipv4/raw.c b/net/ipv4/raw.c
index 9d01006d8189e..dcd554d920825 100644
--- a/net/ipv4/raw.c
+++ b/net/ipv4/raw.c
[ ... ]
quoted hunk ↗ jump to hunk
@@ -48,31 +47,25 @@
#include <linux/sockios.h>
#include <linux/socket.h>
#include <linux/in.h>
-#include <linux/mroute.h>
[ ... ]
quoted hunk ↗ jump to hunk
#include <linux/rtnetlink.h>
#include <linux/proc_fs.h>
#include <linux/seq_file.h>
-#include <linux/netfilter.h>
-#include <linux/netfilter_ipv4.h>
#include <linux/compat.h>
#include <linux/uio.h>
[Severity: Low]
This isn't a bug, but some leftovers from the move seem to remain in
raw.c.
Just below this include block, raw.c still has its own copy of the
struct:
net/ipv4/raw.c:
#include <linux/compat.h>
#include <linux/uio.h>
struct raw_frag_vec {
struct msghdr *msg;
union {
struct icmphdr icmph;
char c[1];
} hdr;
int hlen;
};
struct raw_hashinfo raw_v4_hashinfo;
All users of struct raw_frag_vec (raw_probe_proto_opt(), raw_getfrag()
and raw_sendmsg()) now live in raw_ipv4.c, which adds an identical
definition. Could the raw.c copy be removed, so the two private
definitions can't drift apart?
Also, <linux/compat.h> stays in raw.c. Its only user was
compat_raw_ioctl() via compat_ptr(), which has moved to raw_ipv4.c.
<linux/sockios.h> is also still included, although the SIOCINQ and
SIOCOUTQ handling moved out.
The other includes that are no longer needed (asm/ioctls.h, mroute.h,
igmp.h, icmp.h, xfrm.h, netfilter*.h) were dropped. Should these ones be
dropped as well?
[ ... ]
quoted hunk ↗ jump to hunk
diff --git a/net/ipv4/raw_ipv4.c b/net/ipv4/raw_ipv4.c
new file mode 100644
index 0000000000000..8d3d6f30b0e80
--- /dev/null
+++ b/net/ipv4/raw_ipv4.c
[ ... ]
quoted hunk ↗ jump to hunk
+#include <asm/ioctls.h>
+#include <linux/igmp.h>
+#include <linux/mroute.h>
+#include <linux/netfilter.h>
+#include <linux/sockios.h>
+#include <linux/stddef.h>
+#include <linux/types.h>
+#include <net/icmp.h>
+#include <net/ip.h>
+#include <net/raw.h>
+#include <net/sock.h>
+#include <net/udp.h>
+#include <net/xfrm.h>
[ ... ]
quoted hunk ↗ jump to hunk
+bool raw_v4_match(struct net *net, const struct sock *sk, unsigned short num,
+ __be32 raddr, __be32 laddr, int dif, int sdif)
+{
[ ... ]
quoted hunk ↗ jump to hunk
+ return raw_sk_bound_dev_eq(net, READ_ONCE(sk->sk_bound_dev_if),
+ dif, sdif);
+}
+EXPORT_SYMBOL_GPL(raw_v4_match);
[Severity: Low]
The new file uses EXPORT_SYMBOL_GPL() for raw_v4_match(), but
<linux/export.h> is not in the include list above. raw.c included
<linux/export.h> directly, and still needs it for raw_v4_hashinfo.
In W=2 builds, check_missing_include_linux_export_h() in
scripts/misc-check flags files like this one:
warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
Would it make sense to add #include <linux/export.h> to raw_ipv4.c, so
this new file doesn't bring in an extra W=2 warning?
[ ... ]
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260928193046.6698-1-fmancera%40suse.de