Thread (3 messages) 3 messages, 3 authors, 22d ago

Re: [PATCH net] cxgb4/ch_ktls: disable softirqs around tid_list erases

flat view

From: patchwork-bot+netdevbpf@kernel.org
Date: 2026-10-02 09:00:06

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller [off-list ref]:

On Wed, 30 Sep 2026 02:37:34 +0900 you wrote:
chcr_ktls_cpl_act_open_rpl() inserts into tid_list from the receive path
using xa_insert_bh().  The array is shared by the adapter's connections
and initialized with XA_FLAGS_LOCK_BH.  However, chcr_ktls_dev_del() and
the chcr_ktls_dev_add() error path use xa_erase(), which takes the XArray
lock without disabling softirqs.

When cleanup runs with softirqs enabled, a receive softirq for another
connection on the same CPU can interrupt the erase and spin on the lock
held by the interrupted task.  Use xa_erase_bh() at both sites to match
the insertion path.

[...]
Here is the summary with links:
  - [net] cxgb4/ch_ktls: disable softirqs around tid_list erases
    https://git.kernel.org/netdev/net/c/4c9dc0faca98

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help